Skip to content

feat(server)!: implement recursive control condition trees#115

Open
lan17 wants to merge 20 commits intomainfrom
codex/feature/sc-58429-condition-trees
Open

feat(server)!: implement recursive control condition trees#115
lan17 wants to merge 20 commits intomainfrom
codex/feature/sc-58429-condition-trees

Conversation

@lan17
Copy link
Contributor

@lan17 lan17 commented Mar 12, 2026 •
edited
Loading

corresponding docs update: agentcontrol/docs-agent-control#28

Summary

  • replace flat control predicates with recursive condition trees across the shared models, engine, server, SDKs, and UI
  • add pre-upgrade control migration tooling plus safe condition_trace metadata for composite evaluation
  • bump package majors and regenerate the TypeScript SDK/API types for the new contract

Scope

  • User-facing/API changes:
    • ControlDefinition now uses a top-level condition tree instead of top-level selector / evaluator
    • controls now support nested and / or / not composition with a hard API depth limit of 6
    • /api/v1 stays the same, but this is a major-version wire break and old SDK majors are unsupported against the new server
    • added make server-migrate-control-conditions MIGRATE_ARGS=--dry-run and make server-migrate-control-conditions MIGRATE_ARGS=--apply
  • Internal changes:
    • recursive engine evaluation with short-circuiting and metadata.condition_trace
    • recursive server-side validation with nested field paths
    • Python SDK recursive leaf checks plus non-blocking server-version mismatch warnings
    • UI condition-tree builder with add/remove/convert/reorder actions and nested error rendering
  • Out of scope:
    • runtime backward-compatibility shims for legacy flat control payloads
    • drag-and-drop tree editing

Risk and Rollout

  • Risk level: high
  • Rollback plan:
    • take a database backup before running the migration apply step
    • if rollout fails before migration, revert to the previous server/SDK major
    • if rollout fails after migration, restore the pre-migration database snapshot before rolling back the server major

Testing

  • Added or updated automated tests
  • Ran make check
  • Manually verified behavior

make check passed, which covered:

  • make server-test
  • make engine-test
  • make sdk-test
  • make evaluators-test
  • repo linting
  • repo typechecking

Notes:

  • the run emitted a few existing third-party warnings (sqlglot[rs] deprecation, Strands resource/deprecation warnings), but the full target passed cleanly

Checklist

  • Linked issue/spec: sc-57582, sc-58429
  • Updated docs/examples for user-facing changes
  • Included any required follow-up tasks

lan17 added 2 commits March 11, 2026 22:03
@lan17
feat!: implement recursive control condition trees
6465572
@lan17
Merge remote-tracking branch 'origin/main' into codex/feature/sc-5842…
46bee1d 
…9-condition-trees

# Conflicts:
#	ui/src/core/page-components/agent-detail/modals/edit-control/edit-control-content.tsx
@lan17 lan17 changed the title feat!: implement recursive control condition trees feat(server)!: implement recursive control condition trees Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.10309% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
models/src/agent_control_models/controls.py 88.11% 12 Missing ⚠️
...agent_control_server/services/control_migration.py 78.57% 9 Missing ⚠️
...erver/src/agent_control_server/endpoints/agents.py 84.09% 7 Missing ⚠️
...ver/src/agent_control_server/endpoints/controls.py 85.71% 7 Missing ⚠️
engine/src/agent_control_engine/core.py 94.17% 6 Missing ⚠️
...ntrol_server/scripts/migrate_control_conditions.py 90.16% 6 Missing ⚠️
sdks/python/src/agent_control/evaluation.py 94.11% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@lan17 lan17 marked this pull request as ready for review March 12, 2026 21:16
This was referenced Mar 12, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lan17